Skip to content

London | 26-ITP-Sept | Maharit Belai | Sprint 2 | Course work - #1543

Closed
MaharitB wants to merge 36 commits into
CodeYourFuture:mainfrom
MaharitB:coursework/sprint2
Closed

MaharitB wants to merge 36 commits into
CodeYourFuture:mainfrom
MaharitB:coursework/sprint2

Conversation

@MaharitB

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1039

Changelist

Answered all the questions provided and have fixed bugs of a given code.

Questions

@netlify

netlify Bot commented Sep 19, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit b55c89a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aae9c7820a53100086dde90
😎 Deploy Preview https://deploy-preview-1543--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@MaharitB MaharitB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 19, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 19, 2026
@MaharitB MaharitB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 19, 2026

@abdishakoor-dev abdishakoor-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I look at the exercises, this branch needs redoing.

You created this branch from your Form Controls branch, then did your Sprint 2 work on it.

Always make a new branch from main, for two reasons. main is the up to date version of the project, so you start from the latest finished work. And a branch brings along everything that is already on it, so starting from main means your branch holds only the task you are working on.

The second reason is what caught you here. Nine Form Controls commits are now part of this PR, and that is what the bot was complaining about. Your last commit put the Form Controls files back, which cleared the bot, but the commits are still on the branch.

Here is how to redo it. You keep all 26 of your Sprint 2 commits:

git switch main
git pull origin main
git switch coursework/sprint2
git switch -c sprint-2
git rebase --onto main cac261e sprint-2
git push --set-upstream origin sprint-2

cac261e is your last Form Controls commit. That line tells git to take everything you did after it and put it on top of main instead.

I ran these commands myself before sending this. All 26 commits move across and the files end up exactly as they are now, so you will not lose any work.

Then run git log main..HEAD before you open the PR. You should see 26 commits, all of them Sprint 2. If anything else shows up, the branch was made from the wrong place.

Open a new PR from the new branch, link to this PR in the description, and close this one. I will go through the exercises there.

@abdishakoor-dev abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 19, 2026
@MaharitB MaharitB removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Sep 20, 2026
@MaharitB MaharitB closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants